Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: add test build to CI workflow. #47

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

klihub
Copy link
Member

@klihub klihub commented Aug 8, 2023

Add a job to do a simple test build as part of the CI workflow. This should make sure that PRs don't break building any of the sample plugins.

Add a job to do a simple test build as part of the CI workflow.
This should make sure that PRs don't break building any of the
sample plugins.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from fuweid August 9, 2023 10:34
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

steps:
- uses: actions/checkout@v3
with:
path: src/github.com/containerd/nri
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete gopath setting in the follow-up pull requests because we already use go.mod.

@fuweid fuweid merged commit c83954f into containerd:main Aug 10, 2023
8 checks passed
@klihub klihub deleted the fixes/test-compile-workflow branch January 31, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants