Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: update nodejs20 #578

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

Desiki-high
Copy link
Contributor

@Desiki-high Desiki-high commented Feb 1, 2024

  1. use nodejs 20 version action: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ .
  2. update golangci-lint v1.55.2 and use official GitHub action for golangci-lint.
  3. use setup-go @v5 native cache ability.
  4. fix lint errors.

@imeoer
Copy link
Collaborator

imeoer commented Feb 2, 2024

@Desiki-high LGTM! Sorry for the conflicts, let's resolve them first.

@Desiki-high Desiki-high force-pushed the action-update-nodejs20 branch 2 times, most recently from f3f4514 to 1427bd5 Compare February 4, 2024 03:49
@Desiki-high
Copy link
Contributor Author

@imeoer Please help to update the release.yml later, if you have the write access.

@Desiki-high Desiki-high force-pushed the action-update-nodejs20 branch 3 times, most recently from a913af7 to 53d363e Compare February 4, 2024 04:41
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (3fcac86) 33.52% compared to head (9dd0af7) 34.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   33.52%   34.64%   +1.12%     
==========================================
  Files          65       65              
  Lines        8287     6552    -1735     
==========================================
- Hits         2778     2270     -508     
+ Misses       5194     3967    -1227     
  Partials      315      315              
Files Coverage Δ
pkg/store/database_compat.go 78.19% <100.00%> (+1.54%) ⬆️
config/daemonconfig/fuse.go 0.00% <0.00%> (ø)
pkg/auth/keychain.go 31.48% <0.00%> (+3.54%) ⬆️
pkg/daemon/daemon.go 0.00% <0.00%> (ø)
pkg/store/database.go 48.68% <75.00%> (+4.52%) ⬆️
pkg/system/system.go 6.16% <0.00%> (+1.36%) ⬆️

... and 55 files with indirect coverage changes

@Desiki-high Desiki-high force-pushed the action-update-nodejs20 branch 3 times, most recently from a4a7cd6 to 7f0b9a6 Compare February 4, 2024 05:19
- use nodejs 20 version action: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ .
- update golangci-lint v1.55.2 and use official GitHub action.
- use setup-go @v5 native cache ability.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high force-pushed the action-update-nodejs20 branch from 7f0b9a6 to 9dd0af7 Compare February 4, 2024 05:22
@imeoer imeoer merged commit 8dbd486 into containerd:main Feb 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants