-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error in Kubelet when using default root directory #603
Conversation
Thanks for the PR! but it seems the string |
@imeoer Thank you for your feedback and review! I have checked and updated the string /var/lib/containerd-nydus across all relevant files, except for two yaml files in the \tests\e2e\k8s directory. Please review the changes and let me know if there's anything else that needs to be adjusted. |
@fappy1234567 Thanks, I think there's no reason to keep |
@imeoer I've already updated the README.md. Let me know if there's anything else that needs attention. |
@fappy1234567 Thanks, the |
@imeoer Thank you for your guidance. I have also updated the tests/e2e/k8s section, but there are some checks that are not passing. When you have a moment, could you please take a look and see if there is anything that needs to be adjusted? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Relevant Issue
Fixes #288
Details
Setting the snapshotter's default root path to /var/lib/containerd/io.containerd.snapshotter.v1.nydus can resolve the issue.