Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update chunkmap suffix #619

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

Desiki-high
Copy link
Contributor

@Desiki-high Desiki-high commented Oct 10, 2024

Nydus latest chunk_map path has changed to {blob_id}.blob.data.chunk_map. Add blobChunkMapSuffixedPath to keep backward compatibility.

@Desiki-high Desiki-high force-pushed the chunkmap-suffix branch 2 times, most recently from 77ca80d to 3a98b05 Compare October 10, 2024 07:24
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 22.07%. Comparing base (50a833f) to head (067f6b2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cache/manager.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   22.07%   22.07%   -0.01%     
==========================================
  Files         122      122              
  Lines       10766    10768       +2     
==========================================
  Hits         2377     2377              
- Misses       8068     8070       +2     
  Partials      321      321              
Files with missing lines Coverage Δ
pkg/cache/manager.go 0.00% <0.00%> (ø)

Add blobChunkMapSuffixedPath to clear latest nydus chunmap: {blob_id}.blob.data.chunk_map

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit d6ca59c into containerd:main Oct 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants