update vsize when lsmt stack files if needed

Signed-off-by: Lanzheng Liu <lanzheng.liulz@alibaba-inc.com>
containerd · Nov 16, 2023 · 930a1f3 · 930a1f3
1 parent 3dc16b2
commit 930a1f3
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 9 deletions.
diff --git a/src/overlaybd/lsmt/file.cpp b/src/overlaybd/lsmt/file.cpp
@@ -603,6 +603,8 @@ class LSMTReadOnlyFile : public IFileRW {
             LOG_ERROR_RETURN(ENOSYS, nullptr, "no underlying files found!");
         return file->filesystem();
     }
+
+    UNIMPLEMENTED(int update_vsize(size_t vsize) override);
     UNIMPLEMENTED(int close_seal(IFileRO **reopen_as = nullptr) override);
 
     // It can commit a RO file after close_seal()
@@ -834,6 +836,31 @@ class LSMTFile : public LSMTReadOnlyFile {
         return 0;
     }
 
+    int update_header_vsize(IFile *file, size_t vsize) {
+        ALIGNED_MEM(buf, HeaderTrailer::SPACE, ALIGNMENT4K)
+        if (file->pread(buf, HeaderTrailer::SPACE, 0) != HeaderTrailer::SPACE) {
+            LOG_ERROR_RETURN(0, -1, "read layer header failed.");
+        }
+        HeaderTrailer *ht = (HeaderTrailer *)buf;
+        ht->virtual_size = vsize;
+        if (file->pwrite(buf, HeaderTrailer::SPACE, 0) != HeaderTrailer::SPACE) {
+            LOG_ERROR_RETURN(0, -1, "write layer header failed.");
+        }
+        return 0;
+    }
+
+    virtual int update_vsize(size_t vsize) override {
+        LOG_INFO("update vsize for LSMTFile ", VALUE(vsize));
+        m_vsize = vsize;
+        if (update_header_vsize(m_files[m_rw_tag], vsize) < 0) {
+            LOG_ERROR_RETURN(0, -1, "failed to update data vsize");
+        }
+        if (update_header_vsize(m_findex, vsize) < 0) {
+            LOG_ERROR_RETURN(0, -1, "failed to update index vsize");
+        }
+        return 0;
+    }
+
     virtual int commit(const CommitArgs &args) const override {
         if (m_files.size() > 1) {
             LOG_ERROR_RETURN(ENOTSUP, -1, "not supported: commit stacked files");
@@ -1011,6 +1038,16 @@ class LSMTSparseFile : public LSMTFile {
         LOG_INFO("segment size: `", mappings.size());
         return 0;
     }
+
+    virtual int update_vsize(size_t vsize) override {
+        LOG_INFO("update vsize for LSMTSparseFile ", VALUE(vsize));
+        m_vsize = vsize;
+        if (update_header_vsize(m_files[m_rw_tag], vsize) < 0) {
+            LOG_ERROR_RETURN(0, -1, "failed to update data vsize");
+        }
+        m_files[m_rw_tag]->ftruncate(vsize + HeaderTrailer::SPACE);
+        return 0;
+    }
 };
 
 class LSMTWarpFile : public LSMTFile {
@@ -1690,6 +1727,7 @@ IFileRW *stack_files(IFileRW *upper_layer, IFileRO *lower_layers, bool ownership
         LOG_ERROR_RETURN(EINVAL, nullptr, "invalid upper layer");
     if (!l)
         return upper_layer;
+
     auto type = u->ioctl(IFileRO::GetType);
     LSMTFile *rst = nullptr;
     IComboIndex *idx = nullptr;
@@ -1702,16 +1740,13 @@ IFileRW *stack_files(IFileRW *upper_layer, IFileRO *lower_layers, bool ownership
         }
         if (!pht->is_sparse_rw()) {
             rst = new LSMTFile;
-            if (u->m_vsize == 0) {
-                u->m_vsize = l->m_vsize;
-                LOG_INFO("update upper vsize as lower vsize, vsize:`", u->m_vsize);
-            }
         } else {
             rst = new LSMTSparseFile;
-            if (u->m_vsize == 0) {
-                u->m_vsize = l->m_vsize;
-                u->m_files[0]->ftruncate(u->m_vsize + HeaderTrailer::SPACE);
-                LOG_INFO("update upper vsize as lower vsize and truncate upper sparse file, vsize:`", u->m_vsize);
+        }
+        // TODO: also for LSMTWarpFile
+        if (u->m_vsize == 0) {
+            if (u->update_vsize(l->m_vsize) < 0) {
+                LOG_ERRNO_RETURN(0, nullptr, "failed to update vsize");
             }
         }
     } else {

diff --git a/src/overlaybd/lsmt/file.h b/src/overlaybd/lsmt/file.h
@@ -74,10 +74,12 @@ class IFileRW : public IFileRO {
         return this->ioctl(Index_Group_Commit, buffer_size);
     }
 
+    // update vsize for current rw layer
+    virtual int update_vsize(size_t vsize) = 0;
+
     // commit the written content as a new file, without garbages
     // return 0 for success, -1 otherwise
     virtual int commit(const CommitArgs &args) const = 0;
-    // virtual int commit(IFile* as) const = 0;
 
     // close and seal current file, optionally returning a new
     // read-only file, with ownership of underlaying file transferred