Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] LSMTSparseFile support close_seal() #217

Merged
merged 1 commit into from
May 23, 2023

Conversation

BigVan
Copy link
Member

@BigVan BigVan commented May 22, 2023

What this PR does / why we need it:

  • close_seal() Method can also convert a LSMTSparseFile as a LSMTReadOnlyFile with 'sparse_rw' tag. Users should be careful to compact such files before uploading them. :D
  • And also, a compacted LSMTReadonlyFile shouldn't be committed twice. This PR adds some format check for it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

#216

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

  close_seal() Method can also convert a LSMTSparseFile as a
LSMTReadOnlyFile with 'sparse_rw' tag

  Users should be careful to compact such files before uploading
them. :D

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit 86c2505 into containerd:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants