Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] generate turboOCI index from a gzip stream buffer #264

Merged
merged 8 commits into from
Dec 8, 2023

Conversation

BigVan
Copy link
Member

@BigVan BigVan commented Sep 11, 2023

What this PR does / why we need it:

To make overlaybd can build a TurboOCI index from a stream buffer,
which can make the building process of turboOCI faster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@BigVan BigVan added the enhancement New feature or request label Sep 11, 2023
@BigVan
Copy link
Member Author

BigVan commented Sep 11, 2023

It is better to merge this PR after v1.0 has been released

@BigVan BigVan force-pushed the gzstream branch 14 times, most recently from 4d3667e to 4de34a9 Compare September 18, 2023 16:35
@BigVan BigVan force-pushed the gzstream branch 2 times, most recently from dc1fbdd to b0abbd9 Compare December 7, 2023 09:30
  - GzStreamFile:
    - do decompress from a stream buffer
    - dump gzip index to a separate file

  - TarMeta:
    TarMeta is a modified structure of TarHeader which include the
inner offset of each object in this tarball

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
    StreamConvertor is a UDS server that can accept gzip data from
Unix domain socket and generate gzip index & tar headers

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
add E2E test for reading a gzip file by gzstream and save
its metadata(gz index & tarmeta) into Overlaybd-turboOCI

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
   - support parsing a YAML file to configure server
   - docker image support

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
src/overlaybd/gzindex/CMakeLists.txt Outdated Show resolved Hide resolved
src/overlaybd/CMakeLists.txt Show resolved Hide resolved
src/overlaybd/gzindex/gzip_index_create.cpp Outdated Show resolved Hide resolved
src/overlaybd/stream_convertor/config.h Outdated Show resolved Hide resolved
src/overlaybd/tar/test/CMakeLists.txt Outdated Show resolved Hide resolved
src/overlaybd/tar/libtar.cpp Outdated Show resolved Hide resolved
Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
Copy link
Contributor

@yuchen0cc yuchen0cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit 0d7b1cf into containerd:main Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants