Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support container registries using Basic Auth #323

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

benwaffle
Copy link
Contributor

What this PR does / why we need it:
Some container registries use just Basic auth to fetch images, instead of the Bearer token flow

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Ben Iofel <bi@fly.io>
@benwaffle benwaffle force-pushed the basic-auth-upstream branch from 39e46c4 to d5778dc Compare April 13, 2024 00:14
Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng
Copy link
Member

@benwaffle Would it be possible to also implement this feature in registryfs v1?

@benwaffle
Copy link
Contributor Author

@liulanzheng sorry, I don't have the time to work on that right now

@liulanzheng
Copy link
Member

@benwaffle ok,let's not support v1 for now, and we can add it later. I will complete it when I have time, and it would be even better if you have time to do it as well.

@liulanzheng liulanzheng merged commit 1aec117 into containerd:main Apr 18, 2024
2 checks passed
@benwaffle benwaffle deleted the basic-auth-upstream branch April 18, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants