[EROFS] Add support for xattr reservation of the base layer rootdir #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsiangkao
reviewed
Jul 29, 2024
src/overlaybd/tar/erofs/liberofs.cpp
Outdated
| @@ -17,6 +17,7 @@ | |||
| #define round_down_blk(addr) ((addr) & (~(SECTOR_SIZE - 1))) | |||
| #define round_up_blk(addr) (round_down_blk((addr) + SECTOR_SIZE - 1)) | |||
| #define min(a, b) (a) < (b) ? (a) : (b) | |||
| #define EROFS_ROOT_ATTR_SIZE (16 * 1024) | |||
There was a problem hiding this comment.
EROFS_ROOT_XATTR_SZ
Otherwise it looks good to me.
hsiangkao
approved these changes
Jul 29, 2024
salvete
changed the title
Set the minimum inline xattr size for the root directory of the base layer, as there may not be enough room for xattr during the incremental build process. Signed-off-by: Hongzhen Luo <hongzhen@linux.alibaba.com>
|
@BigVan PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set the minimum inline xattr size for the root directory of the base layer, as there may not be enough room for xattr during the incremental build process.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: