replace testify with stdlib in tests #21
Merged
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like we only minimally depended on testify, so we might as well use stdlib. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Nov 19, 2024
defaults_windows_test.go
Outdated
| @@ -323,7 +328,9 @@ func TestMatchComparerMatch_LCOW(t *testing.T) { | |||
| match: true, | |||
| }, | |||
| } { | |||
| assert.Equal(t, test.match, m.Match(test.platform), "should match %b, %s to %s", test.match, m.Platform, test.platform) | |||
| if actual := m.Match(test.platform); actual != test.match { | |||
| t.Errorf("should match %b, %s to %s", test.match, m.Platform, test.platform) | |||
There was a problem hiding this comment.
Heh; looks like the linter now actually picked up an existing bug
thaJeztah
force-pushed
the
stdlib_testing
branch
from
7472697 to
86a86b7
Compare
|
Heh, yeah, found this stashed locally, so thought I'd push it, but I'm not really attached to it if others still find it useful to have the assert available (testify is still in the dependency tree otherwise, but it may save a bit on maintenance not having to keep it up-to-date) |
|
+25 −15 Maybe it's not popular, but I am a fan of testify rather than having to repeat the |
dmcgowan
approved these changes
Nov 20, 2024
kzys
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we only minimally depended on testify, so we might as well use stdlib.