We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can_handle
containerd-shim-wasm
Based on @Mossaka suggestion, can_handle function appears to duplicate the code several times.
We were able to move this function into container-shim-wasm.
container-shim-wasm
The function is used in all of the following places and has the same functionality:
runwasi/crates/containerd-shim-wasmedge/src/executor.rs
Lines 26 to 28 in d0a1a1c
Lines 60 to 62 in d0a1a1c
runwasi/crates/containerd-shim-wasmtime/src/executor.rs
Lines 29 to 31 in 7e978ed
Lines 56 to 58 in 7e978ed
We might be able to move him to the crates/containerd-shim-wasm/src/exector_util.rs file.
crates/containerd-shim-wasm/src/exector_util.rs
The text was updated successfully, but these errors were encountered:
libcontainer
Successfully merging a pull request may close this issue.
Based on @Mossaka suggestion,
can_handle
function appears to duplicate the code several times.We were able to move this function into
container-shim-wasm
.The function is used in all of the following places and has the same functionality:
runwasi/crates/containerd-shim-wasmedge/src/executor.rs
Lines 26 to 28 in d0a1a1c
runwasi/crates/containerd-shim-wasmedge/src/executor.rs
Lines 60 to 62 in d0a1a1c
runwasi/crates/containerd-shim-wasmtime/src/executor.rs
Lines 29 to 31 in 7e978ed
runwasi/crates/containerd-shim-wasmtime/src/executor.rs
Lines 56 to 58 in 7e978ed
We might be able to move him to the
crates/containerd-shim-wasm/src/exector_util.rs
file.The text was updated successfully, but these errors were encountered: