Provide a simplified API when using libcontainer
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was
linked to
issues
Sep 5, 2023
jprendes
force-pushed
the
simple-container-api
branch
4 times, most recently
from
c8991d9 to
f7a4c4f
Compare
|
I did some small refactor to the The Something missing from |
jprendes
force-pushed
the
simple-container-api
branch
5 times, most recently
from
c728405 to
2234280
Compare
jprendes
force-pushed
the
simple-container-api
branch
2 times, most recently
from
e0d7179 to
1ae4b23
Compare
|
Need a rebase |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
simple-container-api
branch
2 times, most recently
from
7eda9b0 to
75955a7
Compare
|
Rebased. E2E failures seem to be sporadic, as re-running produces failures on a different set of nodes. |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
simple-container-api
branch
from
75955a7 to
426b37e
Compare
Mossaka
approved these changes
Sep 11, 2023
Mossaka
added a commit
to Mossaka/shims
that referenced
this pull request
Sep 11, 2023
This commits updates to use the latest API from the `containerd-shim-wasm` crate. It follows the PR containerd/runwasi#293 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Mossaka
added a commit
to Mossaka/shims
that referenced
this pull request
Sep 19, 2023
This commits updates to use the latest API from the `containerd-shim-wasm` crate. It follows the PR containerd/runwasi#293 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Mossaka
added a commit
to Mossaka/shims
that referenced
this pull request
Sep 21, 2023
This commits updates to use the latest API from the `containerd-shim-wasm` crate. It follows the PR containerd/runwasi#293 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Mossaka
added a commit
to deislabs/containerd-wasm-shims
that referenced
this pull request
Sep 21, 2023
* chore: use the Engine API from containerd-shim-wasm crate This commits updates to use the latest API from the `containerd-shim-wasm` crate. It follows the PR containerd/runwasi#293 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com> Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
libcontainermany of the functionalities from thesandbox::Instancetrait can be delegated to the actual OS container. This can be seen in the current implementation of the shims that build on top oflibcontainer, where the same code pattern is seen in all of them.This PR attempts to capture those patterns and provide a simplified API when wasm container is running inside of an OS container.
This PR introduces an
Enginetrait. This trait is very similar tolibcontainer'sExecutortrait, but intends to be OS agnostic.See the
WasmEdgeEngineandWasmTimeEnginefor reference implementations.The name
Engineis chosen because this type eventually becomes thesandbox::Instance::Enginetype in theInstanceimplementation.For reference, these are the changes to adopt this API in
containerd-wasm-shim: deislabs/containerd-wasm-shims@main...jprendes:containerd-wasm-shims:runwasi-simple-apiThis PR superseeds #250