chore: use the Engine API from containerd-shim-wasm crate #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
suggested changes
Sep 12, 2023
There was a problem hiding this comment.
Most of the comments are just suggestion. The main thing that needs fixing is that the default can_handle is not suitable for most of the shims (it might be ok for lunatic).
Could you rename the executor.rs files to engine.rs?
I think many of the crates dependencies can be dropped now, just to take some examples from lunatic's Cargo.toml:
- libcontainer
- nix
- serde
- serde_json
- thiserror
- libc
- chrono
- oci-spec
- utils
- clap (needs removing the
derive(Args)incommon.rs)
But all shims could use a little clean up.
Also I believe the utils crate be removed.
|
Thanks for your careful review of this PR! @jprendes I have resolved all your comments. Could you PTAL? |
This commits updates to use the latest API from the `containerd-shim-wasm` crate. It follows the PR containerd/runwasi#293 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits updates to use the latest API from the
containerd-shim-wasmcrate. It follows the PR containerd/runwasi#293FYI: @jprendes