[rfc] Add simplified libcontainer instance API #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
force-pushed
the
simple-api
branch
2 times, most recently
from
243c034 to
da9b050
Compare
Mossaka
reviewed
Aug 18, 2023
jsturtevant
reviewed
Aug 21, 2023
| ENGINE_NAME | ||
| } | ||
|
|
||
| fn run(&self, ctx: RuntimeContext, _spec: &Spec) -> anyhow::Result<i32> { |
There was a problem hiding this comment.
I like how this new interface makes the shim implementors only need to know about their particular runtime and how to configure it.
There was a problem hiding this comment.
Do you think we could use a similar API for windows?
i.e., do the normal setup for a windows container, and then let the implementor run the runtime inside the container.
|
Need a rebase |
jprendes
force-pushed
the
simple-api
branch
2 times, most recently
from
921ab1b to
6204ba7
Compare
|
Would you like to talk about this RFC on tomorrow's CG meeting? @jprendes |
|
Yep, that's a good plan :-) |
|
Cool, I've added it to the agenda |
jprendes
force-pushed
the
simple-api
branch
3 times, most recently
from
2fad87b to
2d024ed
Compare
jprendes
force-pushed
the
simple-api
branch
2 times, most recently
from
2fdd23f to
8d8b9e8
Compare
Mossaka
reviewed
Aug 31, 2023
crates/containerd-shim-wasm/src/libcontainer_instance/executor.rs
Outdated
Show resolved
Hide resolved
jprendes
force-pushed
the
simple-api
branch
9 times, most recently
from
ff97934 to
301363d
Compare
jprendes
force-pushed
the
simple-api
branch
3 times, most recently
from
dbd7c47 to
1c5b80a
Compare
jprendes
force-pushed
the
simple-api
branch
2 times, most recently
from
8c409b7 to
cd8026c
Compare
jprendes
force-pushed
the
simple-api
branch
2 times, most recently
from
8abfe99 to
60c0f81
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
|
Closing in favor of #293 |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
The intention of this PR is to receive feedback on a proposed simplified API when using
libcontainer.This API introduces an
Enginetrait fulfilling a similar role to thelibcontainer'sExecutortrait.To implement a new runtime, just implement the
Enginetrait. See the changes to the wasmedge shim.