Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset stdio in tests #299

Closed
wants to merge 1 commit into from
Closed

Conversation

jprendes
Copy link
Collaborator

@jprendes jprendes commented Sep 7, 2023

At some point we had this functionality, but at some other point it broke with lots of refactoring around it. I couldn't pin point exacly where.
This PR adds that functionality to the Stdio mod and uses it in tests.

@jprendes jprendes marked this pull request as ready for review September 7, 2023 13:25
@jprendes jprendes force-pushed the fix-stdio-in-tests branch 2 times, most recently from 8bc2480 to 2a7f8b0 Compare September 8, 2023 23:46
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mossaka
Copy link
Member

Mossaka commented Sep 11, 2023

Need a rebase

@jprendes
Copy link
Collaborator Author

this commit was merged as part of #250 .

@jprendes jprendes closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants