feat(tracing): add tracing instruments to containerd-shim-wasm #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
changed the title
this commit adds tracing instrument macros to functions in the containerd-shim-wasm crate to capture spans of each function including its parameters and results. these spans can be in turn be collected using tracing-opentelemetry and opentelemetry SDK at the shim binary level and output to collectors like Jeager endpoint. Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
jsturtevant
reviewed
May 6, 2024
There was a problem hiding this comment.
A few questions about the level and ability to opt/in out. Although we support it not everyone might have a OTEL environment set up, if they don't do they pay performance hit for it being enabled?
| @@ -36,6 +37,7 @@ macro_rules! revision { | |||
| }; | |||
| } | |||
|
|
|||
| #[instrument(skip_all, parent = Span::current(), level= "Info")] | |||
There was a problem hiding this comment.
Do we want all of these at Info? Is there a performance overhead?
| @@ -44,6 +44,7 @@ ttrpc = "0.8.0" | |||
| wat = "1.206" | |||
| windows-sys = "0.52" | |||
| serial_test = "2" | |||
| tracing = "0.1" | |||
There was a problem hiding this comment.
Should this be an optional feature in the case downstream shims don't use it? containerd/rust-extensions#260
|
@Mossaka and I chatted offline, there isn't a major overhead (>1ms) so we will go ahead with this and can always adjust as need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds tracing instrument macros to functions in the containerd-shim-wasm crate to capture spans of each function including its parameters and results.
these spans can be in turn be collected using tracing-opentelemetry and opentelemetry SDK at the shim binary level and output to collectors like Jeager endpoint.
Demo: https://github.com/Mossaka/runwasi/tree/otel-wasmtime