-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Engine
from InstanceConfig
#774
base: main
Are you sure you want to change the base?
Conversation
24c5373
to
5ff77cb
Compare
8c7ce9c
to
f2ca823
Compare
Converting to draft until I figure out how to deal with the regression in wasmtime. |
This seems like the right thing to do since resolves a bunch of outstanding issues. This sharing of the engine was one of the "benefits" as I understood. It is such a small amount of shared memory/additional cpu, I don't think it will really be something that will be noticed but did we measure the chain against the bench mark at all? |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
There seem to be a regression where wasmtime e2e tests are timing out, so that's a first indication. @jsturtevant if you know how to get the benchmark reports for PRs, please let me know :-) |
68a83fc
to
d26416d
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
d26416d
to
1082ac4
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
This PR removes the
Engine
generic fromInstanceConfig
.As we move away from reusing one engine for all containers, we don't need to pass the engine around anymore.
This is a breaking change.