Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make precompile and can_precompile not take self #776

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jprendes
Copy link
Collaborator

This PR makes it so that precompile and can_precompile do not take self.

The main intention is that ideally we would not need an engine to precompile.
If a runtime can precompile without instantiating the wasm runtime, that would be ideal.

This would allow us to move all engine creation inside of the zygote process.

This makes tests a bit more finicky, as configuring the fake engine is not as simple.

However, the non-test code changes are rather straight forward.

This is marked as draft as I'm still exploring options.

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes
Copy link
Collaborator Author

@jsturtevant , what do you think of doing something like this?

My main complain is that it makes the engine precompilation kind of a "global" thing.

Maybe an "EngineBuilder" would be a better idea, and we can move the precompilation to the engine builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant