Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cargo.lock to fix too new version break build #317

Closed
wants to merge 1 commit into from

Conversation

ningmingxiao
Copy link

@ningmingxiao ningmingxiao commented Sep 29, 2024

because ttrpc-compiler update to 0.6.3 will cause build error.
now some tag and release version can't use cargo build (some package was updated).So it is necessary to add vendor or Cargo.lock to project.

@mxpv @Burning1020
can you review this pr ? Thank you.

@github-actions github-actions bot added T-docs Improvements or additions to documentation T-CI Changes in project's CI labels Sep 29, 2024
@github-actions github-actions bot removed the T-CI Changes in project's CI label Sep 29, 2024
@github-actions github-actions bot removed the T-docs Improvements or additions to documentation label Sep 29, 2024
@ningmingxiao ningmingxiao changed the title support to build offline to fix too new version break build add Cargo.lock to fix too new version break build Sep 29, 2024
@mxpv
Copy link
Member

mxpv commented Sep 30, 2024

Cargo.lock would make more sense for binaries.
I think we should start pinning ttrpc version in Cargo.toml (like ttrpc = "=exact_version") since there are breaking changes every now and then.

@mxpv
Copy link
Member

mxpv commented Oct 3, 2024

I've pinned ttrpc versions. Going to close this one.

@mxpv mxpv closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants