Preserve TOC item IDs when cloning memory metadata reader. #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimberezniker
force-pushed
the
preserve_ids
branch
2 times, most recently
from
db20b2c
to
b061f47
Compare
|
@ktock FYI |
As the IDs are used for computing cache keys, it's important that they do not change. Prior to this change, background fetching would clone the reader and populate the cache with entries using possibly incorrect keys. This patch changes the clone behavior to copy over the original ID mappings. Note that I also removed the locks around the ID maps as these maps are never updated after the reader is created. Fixes containerd#842 Signed-off-by: Vadim Berezniker <vadim@berezniker.com>
vadimberezniker
force-pushed
the
preserve_ids
branch
from
b061f47
to
ec2b28a
Compare
Signed-off-by: Vadim Berezniker <vadim@berezniker.com>
vadimberezniker
force-pushed
the
preserve_ids
branch
from
0d08c7d
to
ffdc792
Compare
ktock
approved these changes
Jul 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the IDs are used for computing cache keys, it's important that they
do not change. Prior to this change, background fetching would clone the
reader and populate the cache with entries using possibly incorrect keys.
This patch changes the clone behavior to copy over the original ID
mappings.
Note that I also removed the locks around the ID maps as these maps are
never updated after the reader is created.
Fixes #842