fs: Try unmount without MNT_FORCE before force unmount #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Nov 7, 2022
|
|
||
| if err := unix.Unmount(mountpoint, 0); err != nil { | ||
| if err != unix.EBUSY { | ||
| return err |
There was a problem hiding this comment.
Do we need to retry on EINTR?
There was a problem hiding this comment.
Thanks for the review. Added retrying on EINTR.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
AkihiroSuda
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run buildkitd + stargz-snapshotter in rootless mode, we get
operation not permittederror on prune.MNT_FORCE flag for umount looks cause this error when it's run by non-root user.
This commit tries to fix this issue by trying umount without MNT_FORCE before the one with MNT_FORCE.