Fix clippy warnings for 1.68 toolchain #178
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 25.76% 25.76%
=======================================
Files 16 16
Lines 2395 2395
=======================================
Hits 617 617
Misses 1778 1778 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Fix clippy warnings for 1.68 toolchain Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
clippy-updates-1.68
branch
from
4e8be5f to
b2c1d3d
Compare
| @@ -8,20 +8,15 @@ use crate::str_lit::StrLit; | |||
| use protobuf_support::lexer::float; | |||
|
|
|||
| /// Protobox syntax | |||
| #[derive(Debug, Clone, Copy, Eq, PartialEq)] | |||
| #[derive(Debug, Clone, Copy, Eq, PartialEq, Default)] | |||
There was a problem hiding this comment.
This change could cause whole project not compatible with lower rust version(<1.66) anymore.
So I think I should limit the Clippy versions instead of this pr.
There was a problem hiding this comment.
Oh interesting. Should we add a skip statement?
What is the typical support for older versions of rust?
There was a problem hiding this comment.
I have file a PR to lock the rust/clippy version #179
|
/close in favor of #179 |
The main branch isn't building due to clippy updates in rust 1.68. This fixes clippy warnings for 1.68 toolchain