Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Skynet Portal URL from config file #113

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Fix: Skynet Portal URL from config file #113

merged 1 commit into from
Mar 6, 2022

Conversation

jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Mar 6, 2022 •
edited
Loading

config file declares the portal url as:

skynet:
  portal_url: https://siasky.net

but the datatype was declared with tag skynet_portal_url which was causing the url defined in the config file to be reset to default always since skynet sdk defaults to siasky.net when skynet url is empty

@jay-dee7 jay-dee7 requested a review from guacamole March 6, 2022 11:26
@jay-dee7 jay-dee7 self-assigned this Mar 6, 2022
@jay-dee7 jay-dee7 added the bug Something isn't working label Mar 6, 2022
guacamole
guacamole approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@jay-dee7 jay-dee7 merged commit 3d9dccc into master Mar 6, 2022
@jay-dee7 jay-dee7 deleted the config-fix branch March 6, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacamole guacamole guacamole approved these changes

Assignees

@jay-dee7 jay-dee7

Labels
bug Something isn't working
Projects
Containerish Road Map 2023-24
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay-dee7 @guacamole