Password management apis #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
guacamole
added
enhancement
guacamole
force-pushed
the
password-management-apis
branch
from
a410535 to
24565f1
Compare
Closed
jay-dee7
reviewed
Mar 31, 2022
config/config.go
Outdated
| @@ -99,6 +101,7 @@ func NewStoreConfig() (*Store, error) { | |||
| } | |||
|
|
|||
| func (sc *Store) Endpoint() string { | |||
| color.Green("stoer: %s", sc) | |||
jay-dee7
reviewed
Mar 31, 2022
| err = json.NewDecoder(ctx.Request().Body).Decode(&pwd) | ||
| if err != nil { | ||
| a.logger.Log(ctx, err) | ||
| return ctx.JSON(http.StatusBadRequest, echo.Map{ |
There was a problem hiding this comment.
@guacamole return the actual error
jay-dee7
reviewed
Mar 31, 2022
| } | ||
| err = a.emailClient.WelcomeEmail(strings.Split(list.Emails, ",")) | ||
| if err != nil { | ||
| return ctx.JSON(http.StatusInternalServerError, echo.Map{ |
There was a problem hiding this comment.
@guacamole add logger here too
jay-dee7
approved these changes
Mar 31, 2022
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
guacamole
force-pushed
the
password-management-apis
branch
from
24565f1 to
681ea12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #115