Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: read configuration from environment variable #139

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

jay-dee7
Copy link
Member

If OPENREGISTRY_CONFIG environment variable is set, we can read our configuration from it.

we can export the entire yaml config as an environment variable and it can be parsed as a yaml Go struct now. Super useful for times when we can't mount the config file directly.

Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com

Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
@jay-dee7 jay-dee7 added enhancement New feature or request P3 P3 labels are used for issues which are not very pressing and we'd love community to work on labels Apr 13, 2022
@jay-dee7 jay-dee7 requested a review from guacamole April 13, 2022 15:51
@jay-dee7 jay-dee7 self-assigned this Apr 13, 2022
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@guacamole guacamole merged commit bd154f8 into master Apr 13, 2022
@jay-dee7 jay-dee7 deleted the read-config-from-env branch April 13, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 P3 labels are used for issues which are not very pressing and we'd love community to work on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants