Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github action for conformance #32

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

jay-dee7
Copy link
Member

This PR adds the OCI_CROSSMOUNT_NAMESPACE environment variable in the
github action config file. This enables us passing all the test cases.

Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com

@jay-dee7 jay-dee7 requested a review from guacamole September 15, 2021 22:01
@jay-dee7 jay-dee7 self-assigned this Sep 15, 2021
@jay-dee7
Copy link
Member Author

@guacamole lets merge this one after #31

Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

This PR adds the `OCI_CROSSMOUNT_NAMESPACE` environment variable in the
github action config file. This enables us passing all the test cases.

Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
@jay-dee7 jay-dee7 force-pushed the github-actions-conformance-fix branch from 375aed0 to 8e1e13f Compare September 17, 2021 13:36
@guacamole
Copy link
Member

Looks awesome, everything passes!!! 🥇

@guacamole guacamole merged commit 77c7eb3 into master Sep 17, 2021
@guacamole guacamole deleted the github-actions-conformance-fix branch September 17, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants