Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Linter fix #41

Merged
merged 1 commit into from
Oct 1, 2021
Merged

refactor: Linter fix #41

merged 1 commit into from
Oct 1, 2021

Conversation

guacamole
Copy link
Member

  • Made code fixes as to comply with golangci linter

@guacamole guacamole requested a review from jay-dee7 October 1, 2021 02:54
@guacamole guacamole self-assigned this Oct 1, 2021
@jay-dee7
Copy link
Member

jay-dee7 commented Oct 1, 2021

@guacamole can you please rebase this branch from master?

@guacamole
refactor: refactored code so as to comply with golangci linter
c7bc9ba 
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
jay-dee7
jay-dee7 approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@jay-dee7 jay-dee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇 thanks for adding this

@jay-dee7 jay-dee7 merged commit aa016d6 into master Oct 1, 2021
@jay-dee7 jay-dee7 deleted the linter-fix branch October 1, 2021 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay-dee7 jay-dee7 jay-dee7 approved these changes

Assignees

@guacamole guacamole

Labels
None yet
Projects
Containerish Road Map 2023-24
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guacamole @jay-dee7