Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes failing linter github action #45

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Oct 4, 2021

This PR pins the version for golangci-lint github action to v1.42.1 which comes with support for all the linters we use.

  • Runs make mod-fix before running linters
  • Increased the timeout for linters to 2m

Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com

@jay-dee7 jay-dee7 requested a review from guacamole October 4, 2021 03:40
@jay-dee7 jay-dee7 self-assigned this Oct 4, 2021
@jay-dee7 jay-dee7 force-pushed the linter-action-fix branch 6 times, most recently from 0d0595d to 225887b Compare October 4, 2021 06:20
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🥇

@guacamole guacamole merged commit 46a4e26 into master Oct 4, 2021
@guacamole guacamole deleted the linter-action-fix branch October 4, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants