Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactored to make code more manageable #46

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

guacamole
Copy link
Member

  • Added auth/basic_auth that contains basic auth functions
  • Added telemetry for future logging and metrics purposes
  • Added router to contain all the routes and register route functions

Signed-off-by: guacamole gunjanwalecha@gmail.com

- added auth/basic_auth that contains basic auth functions
- added telemetry for future logging and metrics purposes
- added router to contain all the routes and register route funtions

Signed-off-by: guacamole <gunjanwalecha@gmail.com>
@guacamole guacamole requested a review from jay-dee7 October 5, 2021 10:35
@guacamole guacamole self-assigned this Oct 5, 2021
Copy link
Member

@jay-dee7 jay-dee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇 thanks for making it this neat. Looks much much better now. muchas gracias

@jay-dee7 jay-dee7 merged commit 59ec472 into master Oct 5, 2021
@jay-dee7 jay-dee7 deleted the refactor branch October 5, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants