fix: bug fix for token auth #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-dee7
force-pushed
the
token-auth
branch
13 times, most recently
from
a693e29 to
7b142e6
Compare
|
@guacamole looks like this PR also breaks our github actions. For us to make this work, I had to change the build/run process in actions from docker to Go binary. Maybe we should track this separately? and not include github actions work in this PR? |
We recently added JWT auth and it introduced a bug that let's anyone push images under any namespace: This PR fixes the bug introduced in PR #48 **johndoe** want to push **app1** so he creates an image named `openregistry.dev/johndoe/app1`, since he's the owner of the image, he can push the image. **johndoe** wants to push **app1** to **janedoe's** account, so he makes a request as: `openregistry.dev/janedoe/app1` and this worked too (which it should not) With this PR, we now check that only `pull` should be allowed and `push` should be restricted to user's own namespace. Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
|
@guacamole i've reverted the changes to |
|
I have opened an issue for same, good to merge 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added JWT auth and it introduced a bug that let's anyone
push images under any namespace:
This PR fixes the bug introduced in PR #48
What bug was introduced?
johndoe want to push app1 so he creates an image named
openregistry.dev/johndoe/app1, since he's the owner of the image, he can push the image.johndoe wants to push app1 to janedoe's account, so he makes a request as:
openregistry.dev/janedoe/app1and this worked too (which it should not)With this PR, we now check that only
pullshould be allowed andpushshould be restricted to user's own namespace.Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com