refactor: removed concurrent retry for failed log messages #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-dee7
force-pushed
the
no-concurrent-retries
branch
2 times, most recently
from
a8e4d68 to
06a8b4d
Compare
We've commented the code for concurrent retries for failed log messages. This was needed since we're flooding the NIC with too many requests and it causes unexpected behaviours Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
jay-dee7
force-pushed
the
no-concurrent-retries
branch
from
06a8b4d to
d66cdcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've commented the code for concurrent retries for failed log messages.
This was needed since we're flooding the NIC with too many requests and
it causes unexpected behaviours
Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com