Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial user signup fix #59

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: initial user signup fix #59

merged 1 commit into from
Nov 2, 2021

Conversation

jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Nov 2, 2021

We get the following error when the first user tries to register for beta:

{"error":"unexpected end of JSON input"}

This happens because we're trying to unmarshal nil byte slice into a struct with string slice in https://github.com/containerish/OpenRegistry/blob/master/cache/register_for_beta.go#L72

Missing return statement in the if condition above it caused this bug

Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com

Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
@jay-dee7 jay-dee7 requested a review from guacamole November 2, 2021 11:31
@jay-dee7 jay-dee7 self-assigned this Nov 2, 2021
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@guacamole guacamole merged commit ac6a928 into master Nov 2, 2021
@guacamole guacamole deleted the cleanup branch November 2, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants