Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Feat: Added environment variables support #11

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

jay-dee7
Copy link
Member

This PR lets us use environment variables for loading api base url. This
enables us to use dynamic configurations.

Also added a simple to follow README configuration on how to run this
project locally

Signed-off-by: jay-dee7 jasdeepsingh.uppal@gmail.com

This PR lets us use environment variables for loading api base url. This
enables us to use dynamic configurations.

Also added a simple to follow README configuration on how to run this
project locally

Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
@jay-dee7 jay-dee7 requested a review from guacamole October 19, 2021 15:53
@jay-dee7 jay-dee7 self-assigned this Oct 19, 2021
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@jay-dee7 jay-dee7 merged commit 6ddf05e into development Oct 19, 2021
@jay-dee7 jay-dee7 deleted the env-vars branch October 19, 2021 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants