cnitool: refactor, add GC, convert to workspace #1076
+420
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors cnitool to be a modern cobra-style program. It also adds STATUS and GC support. Finally it uses go workspaces to allow for separate `go.mod` files. Signed-off-by: Casey Callendrello <c1@caseyc.net>
maiqueb
reviewed
May 29, 2024
| for _, netns := range args[1:] { | ||
| pair := strings.Split(netns, ":") | ||
| ifname := "eth0" | ||
| if len(pair) > 1 { |
There was a problem hiding this comment.
in this scenario - e.g. /var/run/netns/arandompod:ens4 - you also need to update the value of the netns, otherwise, you'd be computing the container ID from the full string, which also has the interface name in.
maiqueb
reviewed
May 29, 2024
|
|
||
| validAttachments = append(validAttachments, types.GCAttachment{ | ||
| IfName: ifname, | ||
| ContainerID: containerID(netns), |
There was a problem hiding this comment.
this is wrong AFAIU - you're checking the containerID based on the "full" netns value, which can include the name of the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors cnitool to be a modern cobra-style program. It also adds STATUS and GC support.
Finally it uses go workspaces to allow for separate
go.modfiles.