Loopback plugin

[zachgersh]

WRT #97

• Introduces ginkgo / gomega style testing (you don't need to look at the diff for that, just dependencies).
• Noop on delete (because you can just nuke a namespace with its lo
• Depending on if you merge the better error handling PR first - I may need to tweak to remove the godeps bit
• priv-net-run now doesn't up a loopback!

[zachgersh]

So - this is red due to the fact that you need to be able to mkdir on /var/run/netns and you get permission denied :/

[zachgersh]

I don't know how to make this go green on travis. Works fine inside of a docker image locally.

[steveej]

Thanks for this one! I think all you need to do is to ./test to sudo ./test in the travis.yml. Please see if that helps and I'll finish reviewing this.

[zachgersh]

@steveej - thanks for the reminder that you could do that, been awhile since I have used travis!

Now, because we installed go without sudo you can't find it when sudo (hence the build fails again).

[zachgersh]

@steveej - good to go now!

[steveej]

Thanks @zachgersh! The new dependencies look like a rather big addition, what exactly do we gain from these?

[zachgersh]

Hey @steveej,

Good question!

Our team (CloudFoundry Container Networking) uses Ginkgo and Gomega to support BDD-style tests (e.g. our vxlan plugin and our runc / cni adapter). We like this style because test descriptions are in plain English, which helps us do test-driven development. The Ginkgo test runner is very mature (e.g. focusing, parallel testing, randomly permuting test order) and there are many Gomega matchers that simplify testing of common scenarios (e.g. MatchJSON).

Our other PR adds test coverage elsewhere, using the same approach.

For what it’s worth, Kubernetes uses Ginkgo and Gomega also.

Our team is actively using CNI and we expect to add more test coverage over time. Using Ginkgo and Gomega in CNI would make that work much easier for us.

[steveej]

Thank you @zachgersh for the explanation. I think we can leverage a full-featured testing framework in CNI. Personally I had not used anything else than Go's built-in testing package but ginkgo looks like a good choice.

Can I ask you to squash the commits before I do a full code review?

[zachgersh]

@steveej look at for a squash shortly. I am going to squash everything except the addition of the ginkgo / gomega dependencies. Should be easier for you to do a code review that way.

[zachgersh]

@steveej believe this should be good to go after the tests pass.

[zachgersh]

@steveej anything else required here?

[steveej]

ping @zachgersh, this needs a rebase now ;)

[zachgersh]

@steveej - sorry for the delay, rebased. Could we try to get this merged today? I am available to help and could jump on IRC if needed.

[steveej]

I think this is good to go. I changed the "Fixes" in the PR comment. Strictly seen it doesn't fix the mentioned issue, which is about upping the loopback interface by default, while PR allows to do this with a designated plugin.