Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate containerID and networkName #698

Merged
merged 1 commit into from
Sep 4, 2019
Merged

validate containerID and networkName #698

merged 1 commit into from
Sep 4, 2019

Conversation

mccv1r0
Copy link
Member

@mccv1r0 mccv1r0 commented Aug 13, 2019

validate containerID and networkName
ensure they contain only letters and numbers

Fixes #679

@mccv1r0 mccv1r0 mentioned this pull request Aug 13, 2019
Closed
@mccv1r0
Copy link
Member Author

mccv1r0 commented Aug 13, 2019

Ugh

Bad response status from coveralls: 405
<html>
<head><title>405 Not Allowed</title></head>
<body bgcolor="white">
<center><h1>405 Not Allowed</h1></center>
<hr><center>nginx</center>
</body>
</html>
The command "if [ "${TARGET}" == "amd64" ]; then
  GOARCH="${TARGET}" ./test.sh;
else
  GOARCH="${TARGET}" go list ./... | xargs -n1 go build -v -o /dev/null
fi
" exited with 1.

@squeed
Copy link
Member

squeed commented Aug 14, 2019

reran the build, it passed.

matthewdupre
matthewdupre requested changes Aug 14, 2019
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
bboreham
bboreham reviewed Aug 14, 2019
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly OK but I have some nits about error handling.

pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/skel/skel.go Outdated Show resolved Hide resolved
libcni/api.go Outdated Show resolved Hide resolved
libcni/api.go Outdated Show resolved Hide resolved
@dcbw
Copy link
Member

dcbw commented Aug 21, 2019

@mccv1r0 can you also update SPEC.md to describe the new restrictions on network name and containerID?

jellonek
jellonek requested changes Aug 21, 2019
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
mars1024
mars1024 reviewed Aug 23, 2019
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/skel/skel.go Show resolved Hide resolved
@mccv1r0
validate containerID and networkName
d8dfb56 
ensure they contain only letters and numbers
@bboreham bboreham merged commit bd64c46 into containernetworking:master Sep 4, 2019
@dtrudg dtrudg mentioned this pull request Jul 2, 2020
Merged
@yinyic yinyic mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars1024 mars1024 mars1024 left review comments

@matthewdupre matthewdupre matthewdupre requested changes

@bboreham bboreham bboreham left review comments

@dcbw dcbw dcbw approved these changes

@jellonek jellonek jellonek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spec: clarify allowed characters in ContainerID
7 participants
@mccv1r0 @squeed @dcbw @jellonek @bboreham @matthewdupre @mars1024