Retry exec commands on text file busy #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars1024
reviewed
Apr 8, 2020
|
As was mentioned in the discussion above, can you move this logic to RawExec (good point, @mars1024). Then we can get this in. |
saschagrunert
force-pushed
the
version-retry
branch
3 times, most recently
from
ab19ddf to
dbed933
Compare
saschagrunert
changed the title
saschagrunert
force-pushed
the
version-retry
branch
from
dbed933 to
2541e81
Compare
This makes the plugin validation a bit more robust by retrying the execution if the plugin is in text file busy state. This can happen if we write the config and the plugin at once. To avoid such races we now try up to 5 seconds for the plugin validation. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
saschagrunert
force-pushed
the
version-retry
branch
from
2541e81 to
e2a7366
Compare
saschagrunert
commented
Apr 16, 2020
Comment on lines
+43
to
61
| // Retry the command on "text file busy" errors | ||
| for i := 0; i <= 5; i++ { | ||
| err := c.Run() | ||
|
|
||
| // Command succeeded | ||
| if err == nil { | ||
| break | ||
| } | ||
|
|
||
| // If the plugin is currently about to be written, then we wait a | ||
| // second and try it again | ||
| if strings.Contains(err.Error(), "text file busy") { | ||
| time.Sleep(time.Second) | ||
| continue | ||
| } | ||
|
|
||
| // All other errors except than the busy text file | ||
| return nil, e.pluginErr(err, stdout.Bytes(), stderr.Bytes()) | ||
| } |
There was a problem hiding this comment.
@dcbw I moved the logic over here, should me make it configurable somehow?
squeed
approved these changes
Apr 22, 2020
dcbw
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the plugin validation a bit more robust by retrying the
execution if the plugin is in text file busy state. This can happen if
we write the config and the plugin at once. To avoid such races we now
try up to 5 seconds for the plugin validation.