Skip to content

Commit

Permalink
revert txqueue due to kernel performance issues
Browse files Browse the repository at this point in the history
Signed-off-by: Hans-Joachim Kliemeck <h0nIg@users.noreply.github.com>
  • Loading branch information
h0nIg committed Sep 20, 2024
1 parent 132789c commit c702643
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions plugins/meta/bandwidth/ifb_creator.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,14 @@ const (
UnShapedClassMinorID uint16 = 1
)

func CreateIfb(ifbDeviceName string, mtu int, qlen int) error {
if qlen < 1000 {
qlen = 1000
}
func CreateIfb(ifbDeviceName string, mtu int, _ int) error {
// numtxqueues mismatch between veth and ifb is causing performance issues
// (similar to mismatch between Host-veth0 and Container peer: https://github.com/torvalds/linux/blob/9d3684c24a5232c2d7ea8f8a3e60fe235e6a9867/drivers/net/veth.c#L1199-L1206)
// do not enable until netlink library offer setting numtxqueues on a ifb device
// if qlen < 1000 {
// qlen = 1000
// }
qlen := 0

err := netlink.LinkAdd(&netlink.Ifb{
LinkAttrs: netlink.LinkAttrs{
Expand Down

0 comments on commit c702643

Please sign in to comment.