deps: bump coreos/go-iptables #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars1024
requested changes
Jan 4, 2021
Closes containernetworking#544 The above issue describes a situation where using the bridge plugin with IPv6 addresses prevented `DEL` from working correctly. `DEL` seems to be failing in the body of `TeardownIPMasq` This arises because: * twice delete postrouting rules: `ipn.String()` `ipn.IP.String()` containernetworking#279 * we are using a version of go-iptables which is bugged for v6 PR github.com/coreos/go-iptables/pull/74 describes why this does not work. The error message is not being checked correctly. Using a later version of go-iptables means that * when the second `ipt.Delete` fails (this is okay) * we will correctly interpret this as an non-fatal error * `TeardownIPMasq` will not prematurely exit the method * `ipt.ClearChain` now can run * `ipt.DeleteChain` now can run This explains why this was working for v4 but not v6 This commit was amended to include v0.5.0 instead of a pseudo-version v0.4.6-0.20200318170312-12696f5c9108 Signed-off-by: toby lorne <toby@toby.codes>
bboreham
reviewed
Jan 6, 2021
Signed-off-by: toby lorne <toby@toby.codes>
mars1024
approved these changes
Jan 7, 2021
smira
added a commit
to smira/pkgs
that referenced
this pull request
Feb 4, 2021
Build CNI plugins instead of downloading pre-built binaries. Bump version to master to fix `ip6tables` issue: containernetworking/plugins#563 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
talos-bot
pushed a commit
to siderolabs/pkgs
that referenced
this pull request
Feb 5, 2021
Build CNI plugins instead of downloading pre-built binaries. Bump version to master to fix `ip6tables` issue: containernetworking/plugins#563 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #544
The above issue describes a situation where using the bridge plugin with IPv6 addresses prevented
DELfrom working correctly.DELseems to be failing in the body ofTeardownIPMasqThis arises because:
ipn.String()ipn.IP.String()change source of ipmasq rule from ipn to ip #279PR coreos/go-iptables/pull/74 describes why this does not work. The error message is not being checked correctly.
Using a later version of go-iptables means that
ipt.Deletefails (this is okay)TeardownIPMasqwill not prematurely exit the methodipt.ClearChainnow can runipt.DeleteChainnow can runThis explains why this was working for v4 but not v6
--
Edit: as mentioned in comments below, I've updated this to vendor
go-iptables@v0.5.0