Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/exclude subnets from traffic shaping2 #921

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Dev/exclude subnets from traffic shaping2 #921

merged 5 commits into from
Apr 8, 2024
+2,886 −610

Commits on Apr 8, 2024

  1. bandwidth: possibility to exclude some subnets from traffic shaping 

    what changed:

we had to refactor the bandwidth plugin and switch from a classless qdisc (tbf)
to a classful qdisc (htb).

subnets are to be provided in config or runtimeconfig just like other parameters

unit and integration tests were also adapted in consequence

unrelated changes:

test fixes: the most important tests were just silently skipped due to ginkgo Measure deprecation
(the ones actually checking the effectiveness of the traffic control)

Signed-off-by: Raphael <oOraph@users.noreply.github.com>
    @oOraph @s1061123
    oOraph authored and s1061123 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    52da39d View commit details
    Browse the repository at this point in the history

  2. bandwidth: possibility to specify shaped subnets or to exclude some f… 

    …rom shaping

Signed-off-by: Raphael <oOraph@users.noreply.github.com>
    @oOraph @s1061123
    oOraph authored and s1061123 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ab0b386 View commit details
    Browse the repository at this point in the history

  3. bandwidth plugin: split unit tests in several files 

    Signed-off-by: Raphael <oOraph@users.noreply.github.com>
    @oOraph @s1061123
    oOraph authored and s1061123 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c666d14 View commit details
    Browse the repository at this point in the history

  4. minor case change 

    even if json unmarshalling in golang with the standard libs is case unsensitive regarding the keys

Signed-off-by: Raphael <oOraph@users.noreply.github.com>
    @oOraph @s1061123
    oOraph authored and s1061123 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    78ebd8b View commit details
    Browse the repository at this point in the history

  5. Simplify unit test 

    Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
    @s1061123
    s1061123 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ccc1cfa View commit details
    Browse the repository at this point in the history