Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSH_PUBKEY expansion into build-arg #669

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix SSH_PUBKEY expansion into build-arg #669

merged 1 commit into from
Jul 11, 2024

Conversation

javipolo
Copy link
Collaborator

Since ssh public key has spaces, it was expanded multiple times

@javipolo
Fix SSH_PUBKEY expansion into build-arg
2bafcd5 
Signed-off-by: Javi Polo <jpolo@redhat.com>
rhatdan
rhatdan approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 6deab0f into containers:main Jul 11, 2024
1 check passed
@javipolo javipolo deleted the fix_ssh_key branch July 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan rhatdan approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

@Gregory-Pereira Gregory-Pereira Awaiting requested review from Gregory-Pereira Gregory-Pereira is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javipolo @rhatdan