add skopeo so that ilab model download will work #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyeder
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
n1hility
approved these changes
Jul 19, 2024
|
@jeremyeder you need to sign your commit. |
|
Also can you put the same change in amd-bootc and intel-bootc. In a perfect world ilab would be an RPM with a requirement on skopeo... |
|
Just an FYI that it’s inclusion at the bootc level is more for friendliness / diagnostic purposes. Ilab will be invoking a skopeo install inside the container with a host volume mount for output. |
|
/hold [rom@rhelai ~]$ rpm -qf /usr/bin/skopeo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for instructlab/instructlab#1756 to work.