Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add example pre-commit config #365

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Jul 1, 2024

Add suggested/example pre-commit configuration for this repo. To use as-is, simply symlink to .pre-commit-config.yaml. Otherwise it can be a basis for a custom configuration.

Also include codespell config w/ repo-specific dictionary extension.

Ref: #364

@cevich cevich force-pushed the example_pre-commit-config branch from 3072637 to 881adcf Compare July 1, 2024 15:38
@cevich cevich marked this pull request as ready for review July 1, 2024 15:42
@cevich cevich requested a review from edsantiago July 1, 2024 15:42
@cevich
Copy link
Member Author

cevich commented Jul 1, 2024

Manually tested with:

pre-commit run --all-files

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feeling pretty nervous about all these additions, so I'm feeling less and less inclined to use this tool myself. I'm OK with committing it for your use, or as a template for others.

The ASCII check seems antiuseful.

skopeo_cidev/setup.sh Outdated Show resolved Hide resolved
ccia/Containerfile Outdated Show resolved Hide resolved
@cevich cevich force-pushed the example_pre-commit-config branch from 881adcf to 33685f7 Compare July 1, 2024 17:17
@cevich
Copy link
Member Author

cevich commented Jul 1, 2024

force-push: Removed require-ascii and related changes.

Re-tested with pre-commit run --all-files

@edsantiago
Copy link
Member

LGTM. Did you mean to remove the .codespell* files?

@cevich
Copy link
Member Author

cevich commented Jul 1, 2024

Did you mean to remove the .codespell* files?

Ooh, I did not. Wonder how that happened.

Add suggested/example `pre-commit` configuration for this repo. To use
as-is, simply symlink to `.pre-commit-config.yaml`.  Otherwise it can
be a basis for a custom configuration.

Fix all findings from the example pre-commit hooks.

Also include codespell config w/ repo-specific dictionary extension.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the example_pre-commit-config branch from 33685f7 to fcf08a3 Compare July 1, 2024 19:49
@cevich
Copy link
Member Author

cevich commented Jul 1, 2024

Force-push: Re-added codespell files.

Thanks @edsantiago 😀

@cevich cevich merged commit 6ec9cee into containers:main Jul 1, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants