-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce impact of networking slowdowns #374
Conversation
@edsantiago PTAL when you have a moment, this isn't critical. |
Cirrus CI build successful. Found built image names and IDs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but do you have any examples of when either of these has failed? My recollection (unsubstantiated) is that jobs flake because they run into the Cirrus timeout. Should that be bumped as well?
I don't, this is purely speculative. I do recall on occasion, an entire repo. mirror (or single package) will flake irrecoverably. In those cases you just need to wait and try again later. Sometimes the next day.
That's my recollection as well, and yes I probably should increase that timeout as well. |
Previously if a repository server, the internet, or the execution environment experienced some kind of networking slowdown, it could lead to a package install or update timeout failure. Increase resiliency in these situations with additional retries, timeouts, and lowered minimum rates. Also increase the timeout on the related Cirrus-CI tasks. Signed-off-by: Chris Evich <cevich@redhat.com>
77f48bd
to
0a1e3db
Compare
force-push: Add/increase timeouts for the Cirrus-CI tasks. @edsantiago In case it's not clear, the primary target is the nested-virt Fedora base image builds. But I'm not married to this PR, it's really just speculation on increasing build-problem/flake resiliency. If you feel it's unnecessary, adds too much complexity, or whatever I'll just close it w/o any hard feelings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cirrus CI build successful. Found built image names and IDs:
|
Identical to #375 (comment) |
Previously if a repository server, the internet, or the execution
environment experienced some kind of networking slowdown, it could lead
to a package install or update timeout failure. Increase resiliency in
these situations with additional retries, timeouts, and lowered minimum
rates. Also increase the timeout on the related Cirrus-CI tasks.