Skip to content

Commit

Permalink
install: Propagate skopeo stderr
Browse files Browse the repository at this point in the history
We're going to need to consistently use a helper to get this right
in the future...basically most uses of `.output()` are wrong.

Signed-off-by: Colin Walters <walters@verbum.org>
  • Loading branch information
cgwalters committed Dec 15, 2023
1 parent 2582ef2 commit e4b24ea
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/src/install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,7 @@ fn skopeo_supports_containers_storage() -> Result<bool> {
let o = run_in_host_mountns("skopeo").arg("--version").output()?;
let st = o.status;
if !st.success() {
let _ = std::io::copy(&mut std::io::Cursor::new(o.stderr), &mut std::io::stderr()); // Ignore errors copying stderr
anyhow::bail!("Failed to run skopeo --version: {st:?}");
}
let stdout = String::from_utf8(o.stdout).context("Parsing skopeo version")?;
Expand Down

0 comments on commit e4b24ea

Please sign in to comment.