Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply not idempotent #234

Closed
cgwalters opened this issue Dec 18, 2023 · 2 comments · Fixed by #256
Closed

apply not idempotent #234

cgwalters opened this issue Dec 18, 2023 · 2 comments · Fixed by #256
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@cgwalters
Copy link
Collaborator

Our implementation of bootc update --apply has an obvious bug; we don't handle the case of
bootc update followed by a bootc update --apply.

We need to compare booted/staged and dispatch on that.
@cgwalters cgwalters added bug Something isn't working good first issue Good for newcomers labels Dec 18, 2023
@jeckersb
Copy link
Contributor

I'd like to take a stab at this tomorrow

@jeckersb
Copy link
Contributor

I'd still like to do this, but on my first foray I ran face-first into my own ignorance of the technical details of ostree. So I've been trying to crash course that to get up to speed. I'll be out starting tomorrow until after the holiday, so if someone else is motivated to take this and run with it, by all means have at it. Otherwise I'll resume this in January.

jeckersb added a commit to jeckersb/bootc that referenced this issue Jan 11, 2024
@jeckersb
upgrade: fix --apply when the desired deployment is already staged
0067a47 
Previously, running:

`bootc update; bootc update --apply`

would result in the system not rebooting to apply the
previously-staged deployment.

Closes: containers#234
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@jeckersb jeckersb mentioned this issue Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade: fix --apply when the desired deployment is already staged jeckersb/bootc
2 participants
@jeckersb @cgwalters