Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove note line from bootc status --json #297

Closed
beav opened this issue Feb 2, 2024 · 1 comment · Fixed by #298
Closed

remove note line from bootc status --json #297

beav opened this issue Feb 2, 2024 · 1 comment · Fixed by #298

Comments

@beav
Copy link

beav commented Feb 2, 2024

The output of bootc status --json has the following line before the json starts:

note: The format of this API is not yet stable

I have some logic that captures the output, but it captures both STDERR and STDOUT which breaks json parsing.

We can fix our parsing, but the smallest fix would be to remove the "note" from the output. The json has a field with "apiVersion":"org.containers.bootc/v1alpha1" which IMO conveys the same thing as the note in a machine-readable way.

cgwalters added a commit to cgwalters/bootc that referenced this issue Feb 2, 2024
Per the issue, having the API format be `v1alpha` is enough.

Closes: containers#297
Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator

but it captures both STDERR and STDOUT which breaks json parsing.

As a general rule though...I think part of the design of Unix having a distinct stderr stream is precisely for use cases like this. I can't imagine it's hard to change the calling tool to capture stderr separately, is it?

Nevertheless I think your overall point is valid, so PR in #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants