Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --version argument #361

Closed
cgwalters opened this issue Feb 26, 2024 · 0 comments · Fixed by #418
Closed

add --version argument #361

cgwalters opened this issue Feb 26, 2024 · 0 comments · Fixed by #418
Assignees
@bcrochet
Labels
enhancement New feature or request

Comments

@cgwalters
Copy link
Collaborator

This would be a generally useful feature. Some notes:

  • Let's output YAML by default, like docker does (also copied into ostree and rpm-ostree)
  • There's some clap magic for doing this I think
  • To implement this we would likely need to change our release process to bump the number in Cargo.toml
  • Open question on whether we want to scrape in the git hash (this is usually defeated/broken by packaging)
@cgwalters cgwalters added the enhancement New feature or request label Feb 26, 2024
@bcrochet bcrochet self-assigned this Feb 26, 2024
bcrochet added a commit to bcrochet/bootc that referenced this issue Mar 22, 2024
@bcrochet
feat(build): Add extra version information
ed11eb5 
Introduce shadow-rs as a dependency. This gives some additional git
information for version info, and integrates with clap very nicely.

Fixes containers#361

Signed-off-by: Brad P. Crochet <brad@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@bcrochet bcrochet mentioned this issue Mar 22, 2024
Closed
bcrochet added a commit to bcrochet/bootc that referenced this issue Mar 22, 2024
@bcrochet
feat(build): Add extra version information
8e7c995 
Introduce shadow-rs as a dependency. This gives some additional git
information for version info, and integrates with clap very nicely.

Fixes containers#361

Signed-off-by: Brad P. Crochet <brad@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
bcrochet added a commit to bcrochet/bootc that referenced this issue Mar 22, 2024
@bcrochet
feat(build): Add extra version information
d0e470c 
Introduce shadow-rs as a dependency. This gives some additional git
information for version info, and integrates with clap very nicely.

Fixes containers#361

Signed-off-by: Brad P. Crochet <brad@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
bcrochet added a commit to bcrochet/bootc that referenced this issue Mar 22, 2024
@bcrochet
feat(build): Add extra version information
d36a13a 
Simple build-time code generation for now. Plan to add git info from the
environment if it exists.

Fixes containers#361

Signed-off-by: Brad P. Crochet <brad@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
bcrochet added a commit to bcrochet/bootc that referenced this issue Mar 22, 2024
@bcrochet
feat(build): Add extra version information
1b12b64 
Simple build-time code generation for now. Plan to add git info from the
environment if it exists.

Fixes containers#361

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@bcrochet bcrochet mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcrochet bcrochet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@cgwalters @bcrochet