Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollback verb #383

Closed
cgwalters opened this issue Mar 8, 2024 · 6 comments
Closed

Add rollback verb #383

cgwalters opened this issue Mar 8, 2024 · 6 comments
Labels
area/updates Related to upgrading between versions enhancement New feature or request

Comments

@cgwalters
Copy link
Collaborator

My original hope was that we'd get away from an imperative-style interface; bootc edit should allow programmatic targeting for scripting cases.

However, a bootc rollback verb would be highly convenient.

@cgwalters cgwalters added enhancement New feature or request area/updates Related to upgrading between versions labels Mar 8, 2024
@cgwalters
Copy link
Collaborator Author

We chatted about this in realtime, I was pushing for a "rollback via targeting previous image tag or sha256 digest" flow. The problem with doing this via sha256 digest is that many default registry configurations aggressively GC untagged images.

So our entrypoint docs should probably push for a workflow of pushing at least two versioned tags per build, a :latest equivalent and a versioned tag.

This all said, there's still a clear use case and value for the low-level technique of reverting to the previous boot entry; it's particularly needed for cases where networking breaks after upgrade, etc.

@vkrizan
Copy link

vkrizan commented Mar 13, 2024

Hello,

I'm trying to help out with the support of greenboot with bootc. I had similar thought regarding adding the rollback verb to the CLI. This verb would be a bit crucial for such support on the greenboot side.

Does bootc or ostree native containers keeps (caches) the rollback image? My understanding is that the variant with ostree keeps the deployment in the systems for a rollback. Can that be done in similar way with the bootc-compatible container images (if the idea is to have bootc "engine" agnostic or not having hard dependency on ostree)?

Thank you.

cc @beav

@say-paul
Copy link

say-paul commented Mar 14, 2024

@vkrizan Greenboot does have a rollback feature and it works the way you understand, under hood greenboot uses rpm-ostree rollback . I dont know bootc rollback would work as its not exactly an ostree system.

@vkrizan
Copy link

vkrizan commented Mar 14, 2024

@say-paul My idea was to extend greenboot to use bootc rollback for bootc systems, however the rollback verb is not yet available (this issue) and I've hit the bootloop issue (fedora-iot/greenboot#135). I might try to contribute this verb to bootc, but I'm not sure if Colin's concerns regarding GC is a blocker for that. (And my Rust knowledge is rusty :-)

@cgwalters
Copy link
Collaborator Author

PR in #447

@runcom
Copy link
Member

runcom commented Mar 28, 2024

closed with #447 (?)

@runcom runcom closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/updates Related to upgrading between versions enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants