Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rollback verb and rollbackQueued status #447

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

cgwalters
Copy link
Collaborator

I'd really hoped to do something more declarative here, and really flesh out the intersections with automated upgrades and automated rollbacks.

But, this just exposes the simple primitive, equivalent to rpm-ostree rollback.

@jmarrero
Copy link
Member

Do we still want to explore the declarative path in the near future?

I'd really hoped to do something more declarative here, and
really flesh out the intersections with automated upgrades
and automated rollbacks.

But, this just exposes the simple primitive, equivalent
to `rpm-ostree rollback`.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator Author

OK yeah, I have a strawman here for a declarative API.

@cgwalters cgwalters marked this pull request as ready for review March 26, 2024 22:41
@cgwalters
Copy link
Collaborator Author

The failure in c9s-dev-integration aarch64 may be coreos/bootupd#633

@henrywang
Copy link
Contributor

henrywang commented Mar 27, 2024

The failure in c9s-dev-integration aarch64 may be coreos/bootupd#633

I think so. The last passed bootupd version is bootupd-202403191914.0.2.18.18.ge29257b-1.el9.x86_64. There's only one commit between e29257b and f361266.

Failure is not caused by this PR. Same failure can be found in PR #445 test.

@vkrizan
Copy link

vkrizan commented Mar 27, 2024

Thank you!

@henrywang
Copy link
Contributor

henrywang commented Mar 27, 2024

@cgwalters @HuijingHei The fix coreos/bootupd#634 works on bootupd-202403271203.0.2.18.22.ge7cb57c-1.el9.aarch64

Copy link
Contributor

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I deployed this via podman-bootc and did an update followed by a rollback and everything worked as expected, and bootc status output looked sane throughout.

@jeckersb jeckersb merged commit 1707bdd into containers:main Mar 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants